[PM-12036] Removing ActiveUserState from vault-onboarding.service.ts #12898
+58
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed Issues (14)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12898 +/- ##
==========================================
+ Coverage 35.30% 35.31% +0.01%
==========================================
Files 2996 2996
Lines 90956 90963 +7
Branches 16980 16981 +1
==========================================
+ Hits 32115 32127 +12
+ Misses 56349 56343 -6
- Partials 2492 2493 +1 ☔ View full report in Codecov by Sentry. |
gbubemismith
requested changes
Jan 23, 2025
apps/web/src/app/vault/individual-vault/vault-onboarding/services/vault-onboarding.service.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/vault/individual-vault/vault-onboarding/vault-onboarding.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/vault/individual-vault/vault-onboarding/vault-onboarding.component.spec.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/vault/individual-vault/vault-onboarding/vault-onboarding.component.ts
Outdated
Show resolved
Hide resolved
…-onboarding.component.spec.ts Co-authored-by: SmithThe4th <[email protected]>
apps/web/src/app/vault/individual-vault/vault-onboarding/vault-onboarding.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Use SingleUserState not ActiveUserState in vault-onboarding.service
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes